Birthday Paradox

i was assigned a short project in c++ today
and i thought that i would share the code that calculates the birthday paradox

#include <iostream>
#include <cstdlib>
using namespace std;

double birthdayCollecter(int B[],int n,double t)
{
    int C;
    C=0;
    for (int h=1; h<=t; h++)
    {
        for (int i=0; i<n; i++)
        {
            bool breaker = false;
            B[i] = (rand() %365 + 1);
            cout<<"\nB["<<i<<"] = "<<B[i];
            for (int j =0; j<i; j++)
            {
                if (B[j] == B[i])
                {
                    C++;
                    cout<<"      "<<C;
                    breaker = true;
                    break;
                }
            }
            if (breaker == true){break;}
        }
    }
    return C;
}
int collectPeople()
{
    cout<<"how many people would you like to check at once : ";
    int people;
    cin>>people;
    while (people>100)
        {
        cout<<"\nSorry pick a number lower then 100, the percent it too high otherwise\n";
        cout<<"how many people would you like to check at once : ";
        cin>>people;
        if (people<100){return people;}
        }
    return people;
}

int main()
{
//this is the intoduction message, it asks the user to input the wanted values
    cout<<"\nwelcome to the birthday paradox calculator \n";
// the number of people to be tested is input and checked   
    int numPeople = collectPeople();
    cout<<"\nok you want to check "<< numPeople <<" People \n";
// the number of wanted simulations is imput   
    cout<<"how many times do you want to run the simulation : ";
    double trials;
    cin>> trials;
    double Count;
    int birthdayArray[numPeople];
// The count of how manny people share birthdays is defined by the Birtday Collecter function
    Count = birthdayCollecter(birthdayArray,numPeople,trials);
    cout<<"\nthe Probablility of two people in a room of "<<numPeople<<" sharing a birthday is : "<< (Count/trials)*100<<"%" ;
    cout<<"\n\n";
   

    return 0;
}

That's not Lisp.

>>2
That's autism.

>not using just a return statement
>instead of a stupid break trick

You didn't use code tags so unfortunately I'm unable to review the code ...  But even so I'm sure I could write this in a much more effecient manner as you are obviously a noob

>>4
not using sage
nor quoting properly

>>5
I'll help >>1 and codeify it


#include <iostream>
#include <cstdlib>
using namespace std;

double birthdayCollecter(int B[],int n,double t)
{
    int C;
    C=0;
    for (int h=1; h<=t; h++)
    {
        for (int i=0; i<n; i++)
        {
            bool breaker = false;
            B[i] = (rand() %365 + 1);
            cout<<"\nB["<<i<<"] = "<<B[i];
            for (int j =0; j<i; j++)
            {
                if (B[j] == B[i])
                {
                    C++;
                    cout<<"      "<<C;
                    breaker = true;
                    break;
                }
            }
            if (breaker == true){break;}
        }
    }
    return C;
}
int collectPeople()
{
    cout<<"how many people would you like to check at once : ";
    int people;
    cin>>people;
    while (people>100)
        {
        cout<<"\nSorry pick a number lower then 100, the percent it too high otherwise\n";
        cout<<"how many people would you like to check at once : ";
        cin>>people;
        if (people<100){return people;}
        }
    return people;
}

int main()
{
//this is the intoduction message, it asks the user to input the wanted values
    cout<<"\nwelcome to the birthday paradox calculator \n";
// the number of people to be tested is input and checked  
    int numPeople = collectPeople();
    cout<<"\nok you want to check "<< numPeople <<" People \n";
// the number of wanted simulations is imput  
    cout<<"how many times do you want to run the simulation : ";
    double trials;
    cin>> trials;
    double Count;
    int birthdayArray[numPeople];
// The count of how manny people share birthdays is defined by the Birtday Collecter function
    Count = birthdayCollecter(birthdayArray,numPeople,trials);
    cout<<"\nthe Probablility of two people in a room of "<<numPeople<<" sharing a birthday is : "<< (Count/trials)*100<<"%" ;
    cout<<"\n\n";
  

    return 0;
}

Now I shell review.

shell

oh my.

Back to code review

birthdayCollecter(int B[]

javafag

for (int h=1; h<=t; h++)

counts from 1
uses h<=t instead of h <= t

breaker = true;

No return statement?


if (people<100){return people;}

redundant check is redundant.

cout<<"how many times do you want to run the simulation : ";
double trials;

double? really?

int birthdayArray[numPeople];

I think the only reason why he allocates data on stack is because he's unaware of vector

double Count;

sometimes he start variables with UPPERCASED letter, sometimes not. Sometimes he uses long varnames(Count), sometimes short(C).
This clearly mean that kid is still questioning his sexuality.

// The count...
    Count

no indentation of comments.

Probability of faggot: >100%

Here goes my sage.