Programming Challenge: Noughts and Crosses

I just got finished with my first program (that is, the first one I haven't just copied out of a book). It's a text based version of Noughts and Crosses (aka Tic-tac-toe) without an AI, and it looks pretty ugly to me. Commenting is half-assed, some variables are given nondescript names, and I can tell that my loop structure can use a little work. Still, it runs.

Show me up, /prog/. Write a more elegant version in the language of your choice. Surely it's not a difficult task for [o][u]EXPERT PROGRAMMERS[/o][/u] such as yourselves. If you've got any suggestions for me, those would be nice, too.


//Noughts and crosses

#include <iostream>
using namespace std;

//Displays board on screen
void dispboard (char d[9]) {
     cout << " " << d[0] << " | " << d[1] << " | " << d[2] << "\n";
     cout << "---+---+---\n";
     cout << " " << d[3] << " | " << d[4] << " | " << d[5] << "\n";
     cout << "---+---+---\n";
     cout << " " << d[6] << " | " << d[7] << " | " << d[8] << "\n";
}

//Horizontal checker function of checkboard
int horicheck (char x[9], char y, int z) {
     if (x[z] == y) {
             if (x[z+1] == y) {
                       if (x[z+2] == y)
                          return 1;
                      
                       else
                           return 0;
             }
             else
                 return 0;
     }
     else
         return 0;
}

//Vertical checker function of checkboard
int verticheck (char x[9], char y, int z) {
     if (x[z] == y) {
             if (x[z+3] == y) {
                       if (x[z+6] == y)
                          return 1;
                      
                       else
                           return 0;
             }
             else
                 return 0;
     }
     else
         return 0;
}

//Top-left to bottom-right diagonal checker function of checkboard
int diagcheck1 (char x[9], char y, int z) {
     if (x[z] == y) {
             if (x[z+4] == y) {
                       if (x[z+8] == y)
                          return 1;
                      
                       else
                           return 0;
             }
             else
                 return 0;
     }
     else
         return 0;
}

//Top-right to bottom-left diagonal checker function of checkboard
int diagcheck2 (char x[9],char y,int z) {
     if (x[z] == y) {
             if (x[z+2] == y) {
                       if (x[z+4] == y)
                          return 1;
                      
                       else
                           return 0;
             }
             else
                 return 0;
     }
     else
         return 0;
}
            
//Checks board for a win condition
//Uses horicheck, verticheck, diagcheck1, and diagcheck2
int checkboard (char a[], char b) {
     if (horicheck (a,b,0) == 1)
        return 1;
     else if (horicheck (a,b,3) == 1)
          return 1;
     else if (horicheck (a,b,6) == 1)
          return 1;
     else if (verticheck (a,b,0) == 1)
          return 1;
     else if (verticheck (a,b,3) == 1)
          return 1;
     else if (verticheck (a,b,6) == 1)
          return 1;
     else if (diagcheck1 (a,b,0) == 1)
          return 1;
     else if (diagcheck2 (a,b,2) == 1)
          return 1;
     else
         return 0;
}

int main () {
    char board[9] = {' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '};
    char curplayer = 'X';
    int done;
    char winner = 'q';
    int turn;
    int fin = 0;
   
    cout << "Noughts and Crosses\n\n";
   
    cout << " 0 | 1 | 2\n---+---+---\n 3 | 4 | 5\n---+---+---\n 6 | 7 | 8\n";
    cout << "To place your nought or cross in a square, type the location of\nits square, as seen above.\n\n";
   
    do {
        cout << curplayer << "'s turn!\n";
        dispboard (board);
        done = 0;
        while (done == 0) {
              cout << "Player " << curplayer << ", please type the location of the square that\n";
              cout << "you wish to place a '" << curplayer << "'this turn. ";
              cin >> turn;
              if (turn >= 0 && turn < 9) {
                 if (board[turn] == ' ') {
                    board[turn] = curplayer;
                    done = 1;
                    cout << "\n'" << curplayer << "' placed!\n";
                 }
                 else
                     cout << "\nThere is already a nought or cross at that location.\n";
              }
               
              else
                  cout << "\nYou did not specifiy a valid square. Locations range from 0 to 8,\nwith 0 being the upper left square and 8 being the bottom left.\n";
          }
         
          if (checkboard (board, 'X') == 1)
                         winner = 'X';
          else if (checkboard (board, 'Y') == 1)
               winner = 'O';
              
          else {
               if (curplayer == 'X')
                  curplayer = 'O';
               else
                   curplayer = 'X';
          }
    } while (winner == 'q');
   
    cout << "Player " << winner << " won the game!";
           
    return 0;
}

Cross my anus.

I had an ncurses version somewhere. Upon misclicking on the grid rather than the space in-between, the program would print ``are you fucking blind'' and proceed to delete files in user's home. I'll try to find it.

>>2
using namespace std;
Stopped reading right there.

>>5

Give me a break, I just started reading my book yesterday.

>>6
There was a time, there was a place, where smacking the student on the hand was considered proper. Nowadays you can't even use implications.

Tell you what, why don't I just code for you, dear, you run along and play.

>>7

That's exactly the point of this thread, I want to see you code.

>>6
Use a condom. And K&R.

/print

[ ][ ][ ]
[ ][ ][ ]
[ ][ ][ ]

import Control.Applicative
import Control.Monad
import Control.Monad.Instances
import Data.List
import Data.Monoid

data Player = None | X | O deriving (Show, Eq)
other X = O
other _ = X
type Board = [[Player]]
instance Monoid Player where
    mempty = None
    None `mappend` a = a
    a `mappend` b = a

initialBoard = replicate 3 (replicate 3 None)
showTile n None = show n
showTile _ p = show p
showRow n = intercalate " | " . zipWith showTile [n..]

drawBoard :: Board -> String
drawBoard = unlines . intersperse "----------" . zipWith showRow [1,4..]

winner = (mconcat .) . sequence $
    [id, (. transpose)] <*> ([id, (. diagonal)] <*> (checkRows <$> [X, O]))

checkRows player = maybe None (const player) . find (all (== player))
diagonal = return . concatMap (take 1) . zipWith id (iterate (tail .) id)

updateNth n f = zipWith id (replicate n id ++ [f] ++ repeat id)
update n player = updateNth (n `div` 3) $ updateNth (n `mod` 3) (const player)

getMove player board = do
    n <- readLn
    if n `elem` [1..9]
        then if concat board !! (n - 1) == None
            then return $ update (n - 1) player board
            else putStrLn "Already taken." >> getMove player board
        else putStrLn "1 to 9, please." >> getMove player board

main = do
    putStrLn $ drawBoard initialBoard
    loop X initialBoard
    where
        loop player board = do
            putStrLn $ show player ++ " to play, choose a numbered square: "
            board' <- getMove player board
            putStrLn $ drawBoard board'
            case winner board' of
                None -> if all (all (/= None)) board'
                    then putStrLn "It's a draw!"
                    else loop (other player) board'
                w -> putStrLn $ "The winner is: " ++ show w

#include <stdlib.h>
#include <curses.h>
#include <signal.h>

char board[3][3] = {{0, 0, 0}, {0, 0, 0}, {0, 0, 0}};
int x_win = 0, o_win = 0;

void done(int _)
{
    exit(endwin());
}

int play_turn(char c)
{
    mvaddch(3, 14, c);

    switch (getch()) {
        case KEY_A1:
            if (board[0][0] == 0) {
                mvaddch(1, 2, c);
                return 0;
            } else return -1;
        case KEY_UP:
            if (board[0][1] == 0) {
                mvaddch(1, 6, c);
                return 0;
            } else return -1;
        case KEY_A3:
            if (board[0][2] == 0) {
                mvaddch(1, 10, c);
                return 0;
            } else return -1;
        case KEY_LEFT:
            if (board[1][0] == 0) {
                mvaddch(3, 2, c);
                return 0;
            } else return -1;
        case KEY_B2:
            if (board[1][1] == 0) {
                mvaddch(3, 6, c);
                return 0;
            } else return -1;
        case KEY_RIGHT:
            if (board[1][2] == 0) {
                mvaddch(3, 10, c);
                return 0;
            } else return -1;
        case KEY_C1:
            if (board[2][0] == 0) {
                mvaddch(5, 2, c);
                return 0;
            } else return -1;
        case KEY_DOWN:
            if (board[2][1] == 0) {
                mvaddch(5, 6, c);
                return 0;
            } else return -1;
        case KEY_C3:
            if (board[2][2] == 0) {
                mvaddch(5, 10, c);
                return 0;
            } else return -1;
        default:
            return -1;
    }

    return 0;
}

int check_victory()
{
    int i, j, x, o;
    for (i = 0; i < 3; ++i) {
        int x_h, x_v, o_h, o_v;
        x_h = x_v = o_h = o_v = 0;

        for (j = 0; j < 3; ++j) {
            if (board[i][j] == 'X') ++x_h;
            if (board[j][i] == 'X') ++x_v;
            if (board[i][j] == 'O') ++o_h;
            if (board[j][i] == 'O') ++o_h;
        }

        if (x_h == 3 || x_v == 3) return x_win = 1;
        if (o_h == 3 || o_v == 3) return o_win = 1;
    }

    x = o = 0;
    if (board[0][0] == 'X') ++x;
    if (board[0][0] == 'O') ++o;
    if (board[1][1] == 'X') ++x;
    if (board[1][1] == 'O') ++o;
    if (board[2][2] == 'X') ++x;
    if (board[2][2] == 'O') ++o;
    if (x == 3) return x_win = 1;
    if (o == 3) return o_win = 1;

    x = o = 0;
    if (board[0][2] == 'X') ++x;
    if (board[0][2] == 'O') ++o;
    if (board[1][1] == 'X') ++x;
    if (board[1][1] == 'O') ++o;
    if (board[2][0] == 'X') ++x;
    if (board[2][0] == 'O') ++o;
    if (x == 3) return x_win = 1;
    if (o == 3) return o_win = 1;

    return 0;
}

int main(int argc, char **argv)
{
    int i;

    signal(SIGINT, done);

    initscr();
    keypad(stdscr, TRUE);
    nonl();
    cbreak();
    noecho();

    mvaddch(1, 4, '|');
    mvaddch(1, 8, '|');
    mvaddch(3, 4, '|');
    mvaddch(3, 8, '|');
    mvaddch(5, 4, '|');
    mvaddch(5, 8, '|');

    for (i = 1; i < 12; ++i) {
        mvaddch(2, i, '-');
        mvaddch(4, i, '-');
    }

    mvaddch(2, 4, '+');
    mvaddch(2, 8, '+');
    mvaddch(4, 4, '+');
    mvaddch(4, 8, '+');

    for (;;) {
        play_turn('X');
        if (check_victory()) break;
        play_turn('Y');
        if (check_victory()) break;
    }

    done(0);
    return 0;
}

printf("A strange game. The only winning move is not to play");

>>12
Excellent.

>>13
hell no

if (board[i][j] == 'O') ++o_h;
if (board[j][i] == 'O') ++o_h;
FROZEN VOID QUALITY