Binary Search Insert Function

I need to use binary search to insert an item into a sorted list.

Here is my code which is not sorting the items correctly.

template<class ItemType> void SortedList<ItemType>::InsertItem(ItemType x)
{
    int location = 0;
    int end = length-1;
    bool moreToSearch;

    moreToSearch = (location<length);

    while(moreToSearch)
        {
            int midPoint = (location + end) / 2;

            if(x>values[midPoint])
                {
                    location = midPoint + 1;
                    moreToSearch = (location<end);
                }   
            else if(x<values[midPoint])
                {
                    end = midPoint -1;
                    moreToSearch = (location<end);
                   
                }
            else
                {
                    moreToSearch = false;
                    location = midPoint;
                    break;
                }
        }

    for(int index=length;index>location;index--)
          values[index] = values[index-1];


    values[location]=x;
    length++;
}


What's wrong?

Hello homework!

Hello ugly indentation!

What's wrong?
You're using SEPPLES.

int midPoint = (location + end) / 2;
int midPoint = location + ((end - location) / 2);

>>5
Go go gadget sixth-grade math!

template<class ItemType>
void SortedList<ItemType>::InsertItem(const ItemType &x)

{
                int lol=0, hai=length;
                while (lol < hai)
                {
                        int midkips = lol+hai >> 1;
                        if (values[midkips] < x)
                                lol =++ midkips;
                        else
                                hai = midkips;
                }
                std::copy_backward(values+lol, values+length, values -~ length)[~0] = x;
                length -=- 1;
}

Just use the STL, that's what it's there for!

Unless you're not allowed to because you came to /prog/ with your FUCKING HOMEWORK, in which case you can go FUCKING DIE!

^{Resurrection bump}

11 Name: Anonymous 2010-11-27 18:09

Don't change these.

Name:		Email:
Entire Thread Thread List

All trademarks and copyrights on this site are owned by their respective parties. All comments and posts are the responsibility of their own posters.
- Tinychan + 2ch Mode -