[HELP] Spam checking [PERL]

I'M NOT GOOD WITH COMPUTERS

sub spamcheck() {
open(SPAM, "<spam.txt") || die 'MISSING';
@raw_data=<SPAM>;
close(SPAM);
for(@raw_data) {
  /^(.*)$/;
  my $blocked = $1;
  die 'SPAM' if $comment =~ $blocked;
 }
}

I'm trying to make some sort of spamchecker so when a person submits a comment, it is checked against spam.txt and if it doesn't match any of the lines, then it is allowed to continute.

However this bit of code isn't working for me. For example, I have spam.txt with several lines of test words, the first line is derp and when I submit a comment with the word derp it doesn't stop the comment from being submitted. However, when I submit a comment with derp and then a newline, it errors as it's supposed to. But it only does with with the first line. The other lines in spam.txt don't trigger it at all.

Please help me.

HURR DURR I DON'T KNOW HOW TO REMOVE A NEWLINE CHARACTER HURRRRR

IHBT

you only took the first line.
try while(<SPAM>)
or alternatively insert local $/ before @raw_data=<SPAM>;

>>4
actually, that second one probably won't work with your code; don't bother

download/buy & read a copy of learning Perl

Use chomp to remove newlines.

Also $comment =~ $blocked; should be $comment =~ /$blocked/;

this is retarded

OP here, I changed my mind:

Don't help me.

>>9
Not me.

OP here, thanks for your suggestions, I'm going to try them out.

I'll post later, I'm going to go hike some hills first.

sub spamcheck() {
  while (<SPAM>) {
    chomp;
    die 'SPAM' if($comment =~ /$_/)
  } or die 'MISSING';
}

As in >>11.


That reminds me, I had a weird problem with the Data::Dumper output of some hash references if I chomped the elements. Maybe I'll post it later.

None of these suggestions seem to work. In fact, I've come to realize that the code I originally posted actually works, with the exception of having to have a newline after the blacklisted item in order to trigger the spam filter hours after you guys had already told me. I just really needed time to let it sink in after experimenting with it. Turns out I was doing it wrong in spam.txt by not putting &lt; instead of < and [ instead of [ so the spam filter would not trigger, obviously.

Also, this is weird, I took my script to another server to test it and it works perfectly, no newline issues. I was not expecting that.

[ instead of [

Oh right, \ doesn't show up in italics, silly BBCode.

This blows, chomp doesn't seem to be doing its thing.

sub spamcheck() {
open(SPAM, "<spam.txt") || die 'spam.txt is missing';
while (<SPAM>) {
  /^(.*?)$/;
  my ($blocked) = ($1);
  chomp($blocked);
  die 'Your post was detected as spam' if $comment =~ /$blocked/i;
 }
}

What am I doing wrong? Spamcheck still isn't triggered unless the blacklisted item is followed by a new line. CHOOOOOOOOMMMMMMP!!!

>>15
maybe your spam.txt is a dos text file and perl is reading it as a unix text file?
"spam\r\n" -> /^(.*?)$/ -> "spam\r"

Build a suffix tree.

wtf is wrong with you, anyone on here should be able to write something this simple in perl without even thinking

i'm at work, on windows, with restricted network access and no perl interprter but i'm going to write it for you

#!/usr/bin/perl

use warnings;
use strict;

sub spamcheck($) {
  my $string = shift;
  open(SPAM, "spam.txt") or die($!);
  while(<SPAM>) {
    return(-1) if($string =~ m/$_/);
  }
  close(SPAM);
  return(1);
}

while(<>) {
  die("SPAM WARNING") unless(spamcheck($_) == 1);
}

print "no spam found...\n";

exit(0);

>>18
perl
without even thinking
（　≖‿≖）

>>18
Perl can run just fine on Windows.

>>20
Yeah, only if everything is installed. But it still runs better on *nix.

>>18
The real question is: Why would anyone want to write in outdated languages like Perl when they could write it much faster and less error-prone in a more modern language?

Next you'll suggest actually doing non-toy projects in LISP. Hahaha.

>>22
1/10
Good look with coding that in bbcode.

>>18
Well, sir, it seems you could not. That bit did not work at all. I don't hold it against you, given the situation you were in.

>>16
You, on the other hand, are a genius.

I amended the code as such:
sub spamcheck() {
open(SPAM, "<spam.txt") || die 'spam.txt is missing';
while (<SPAM>) {
  /^(.*?)(\r*\n*)$/;
  die 'Your post was detected as spam' if $comment =~ /$1/i;
 }
}

It works perfectly now! Thank you

STOP HELPING PEOPLE!!!

>>25
GO BACK TO /b/!!!

28 Name: Anonymous 2011-02-03 4:01

Don't change these.

Name:		Email:
Entire Thread Thread List

All trademarks and copyrights on this site are owned by their respective parties. All comments and posts are the responsibility of their own posters.
- Tinychan + 2ch Mode -