What is the EVOLUTIONARY ADVANTAGE...

of female spiders who eat the males?

If that same male was not eaten, but went on to impregnate more females, then shouldn't that trait be favored over being eaten?

In most cases the female tries to eat the male from the beginning. It has nothing to do with the act of sex. There's plenty of evolutionary advantage in being an all around territorial cannibal.