Return Styles: Pseud0ch, Terminal, Valhalla, NES, Geocities, Blue Moon. Entire thread

Can /prog/ please comment on my code?

Name: Anonymous 2010-08-02 19:20


class prob3{
   
    static long BigBossPrimeOne;
   
    public static void primeFactor(long n){
    boolean prime = true;
    long n1=0;
    long n2=0;
    for(long i=2;(i<=(n/2))&&(prime!=false);i++)
        if ((n%i)==0){
        prime = false;
        n1=i;
        n2=n/i;   
        }   
    if ((prime==true)&&(n>BigBossPrimeOne))
        BigBossPrimeOne = n;
   
    if (prime==false){
        primeFactor(n1);
        primeFactor(n2);
        }            
    }

    public static void main(String args[]){
 
    primeFactor(600851475143L);
    System.out.println(BigBossPrimeOne);
    }

}


I'm just doing the Euler thing to pass the time and I thought why not post this on /prog/ for some insight.

Using the Java language.

Feel free to give me any advice.

Thanks!

Please don't mind the presentation. It's the first time using Emacs and I was under the clock (did this in 15 minutes).

Name: Anonymous 2010-08-02 21:45

>>21: In function ‘main’:
>>21: warning: ISO C90 does not support ‘long long’
>>21:4:26: error: use of C99 long long integer constant
>>21:7: warning: ISO C90 does not support ‘long long’
>>21:7: error: ‘for’ loop initial declaration used outside C99 mode
>>21:9: warning: ISO C90 does not support the ‘ll’ printf length modifier
>>21: At top level:
>>21:3: warning: unused parameter ‘argc’
>>21:3: warning: unused parameter ‘argv’

Newer Posts
Don't change these.
Name: Email:
Entire Thread Thread List