Critique my asm

Hi BBCode EXPERT here, OK so im trying to learn x86 ASM, please rip me to pieces for being so shit at it, heres my fibonacci function:
.text.globl_fib_fib:pushl%ebpmovl[i]%esp,%ebpsubl    $12,%espmovl    8(%ebp),%eaxcmpl    $1,%eaxjle    L1movl    8(%ebp),%eaxsubl    $1,%eaxmovl%eax, (%esp)call    _fibmovl%eax, 4(%esp)movl    8(%ebp),%eaxsubl    $2,%eaxmovl%eax, (%esp)call_fibaddl    4(%esp),%eaxleaveretL1:movl    $1,%eaxleaveret
    .subsections_via_symbols

fib: ; calculates (ECX-1)th fibonacci number in EAX
 mov eax 1 | cdq
 :fibloop
 add eax edx | xchg eax edx
 loop :fibloop
 ret